Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote:
>
>> +/*****************************************************************************
>> + * VLYNQ Bus
>> + ****************************************************************************/
>
> Why not simply use:
>
> /* VLYNQ Bus */
>
> You have deleted lots of whitespaces, but added more *.
>
"good enough for ARM[1]" :)
Compromise on this instead?
----
/*
* VLYNQ Bus
*/
----
>> @@ -70,7 +71,6 @@ console_initcall(ar7_init_console);
>> * Initializes basic routines and structures pointers, memory size (as
>> * given by the bios and saves the command line.
>> */
>> -
>> void __init plat_mem_setup(void)
>> {
>> unsigned long io_base;
>> @@ -88,6 +88,5 @@ void __init plat_mem_setup(void)
>> prom_meminit();
>>
>> printk(KERN_INFO "%s, ID: 0x%04x, Revision: 0x%02x\n",
>> - get_system_type(),
>> - ar7_chip_id(), ar7_chip_rev());
>> + get_system_type(), ar7_chip_id(), ar7_chip_rev());
>> }
>
> Perhaps you can use pr_info() instead of printk(KERN_INFO) too, of
> course, if there are more printk(KERN_...), you can replace them by
> pr_xxx defined in include/linux/kernel.h
>
I'm not responsible for that printk()...although the others I will admit
to :)
I'll roll out a replacement later today hopefully.
Cheers
--
Alexander Clouter
.sigmonster says: Vini, vidi, Linux!
-- Unknown source
