Hi, On Wed, 2009-11-04 at 12:19 +0100, Ralf Baechle wrote: > On Wed, Nov 04, 2009 at 07:04:12PM +0800, Wu Zhangjin wrote: > > > > Small question : Why don't you restrict to 64bit kernels only ? From > > > what I remember from some discussions with ST, trying to use a 32-bit > > > kernel on 2f is a nice way to get troubles. It would be better imho to > > > forbid such a configuration. As a side effect, this will remove all > > > 'defined(CONFIG_64BIT)' parts of your #ifdef tests. > > > > > > > It's hard to make such a decision ;) Perhaps some guys want to play with > > the 32bit version. > > We have other systems where 32-bit kernel support is just remarkably ugly. > We've dropped 32-bit support for the SGI IP32 aka O2 - nobody seems to even > have really noticed that. The Sibyte systems would be good candidates to do > the same as accesses to outside the 32-bit address space are needed very > frequently. > So, we really remove the 32bit support? 1312 config CPU_LOONGSON2 1313 bool 1314 select CPU_SUPPORTS_32BIT_KERNEL --> remove it? 1315 select CPU_SUPPORTS_64BIT_KERNEL 1316 select CPU_SUPPORTS_HIGHMEM If you all agree, I will send a new patch to remove the above line and resend the corresponding patches without 32bit support, and removed the relative CONFIG_64BIT lines in the patches too. Regards, Wu Zhangjin