On Wed, 2009-11-04 at 15:15 +0100, Ralf Baechle wrote: > On Wed, Nov 04, 2009 at 07:18:47PM +0800, Wu Zhangjin wrote: > > > In reality, fuloong2e, fuloong2f and yeeloong2f work fine with RTC_LIB, > > but relative patches need to append to drivers/rtc/rtc-cmos.c and also > > need a RTC platform device. If what I remembered is right, Gdium also > > need corresponding patches to make it work with RTC_LIB. > > > > Herein, I just let the basic support for those machines work, and then, > > the RTC_LIB support will be sent out later. > > > > and a small question: if legacy RTC driver works well on these machines, > > why should we forbid people to use it? I think it's better to remove the > > "select RTC_LIB" line for MIPS, and then, the people will be free to > > choose what they want, and even for the users whose platform not support > > RTC_LIB. > > RTC_LIB is the way to go; the non-RTC_LIB drivers are there only for > backward compatbility. A grep through the defcconfig files for all > platforms on all architectures finds that by now all have set > CONFIG_RTC_LIB and the remaining users of CONFIG_RTC, CONFIG_JS_RTC, > CONFIG_GEN_RTC, CONFIG_EFI_RTC, CONFIG_DS1302 (which all depend on !RTC_LIB) > are all defconfig files which seem to be slowly bitrotting. > > Time to axe !RTC_LIB? I'm tempted. > Okay, later, I will send the patches for RTC_LIB support asap, I'm testing it currently ;) Regards, Wu Zhangjin
