Le Friday 05 June 2009 16:58:42 castet.matthieu@xxxxxxx, vous avez écrit : > Hi Florian, > > Quoting Florian Fainelli <florian@xxxxxxxxxxx>: > > Your driver looks good, could you turn this into a platform device/driver > > instead ? You declare bcm47xx_wdt_platform_device which is unused and you > > also declare a MODULE_ALIAS which suggets it is one. > > What's the advantage of using platform device/driver ? > Not all watchdog driver use it (for example softdog). > This seems useless in this case because the driver don't have any resource, > don't care about suspend/resume and add complexity in the code (2 registers > in module probe, ...). Indeed, I was suggesting that either you turn it into a full platform driver or your remove references to it (bcm47xx_wdt_platform_device and MODULE_ALIAS). -- Best regards, Florian Fainelli Email : florian@xxxxxxxxxxx http://openwrt.org -------------------------------
