Salut Matthieu, Le Thursday 04 June 2009 22:24:56 matthieu castet, vous avez écrit : > This add watchdog driver for broadcom 47xx device. > It uses the ssb subsytem to access embeded watchdog device. > > Because the watchdog timeout is very short (about 2s), a soft timer is used > to increase the watchdog period. > > Note : A patch for exporting the ssb_watchdog_timer_set will > be submitted on next linux-mips merge. Without this patch it can't > be build as a module. Your driver looks good, could you turn this into a platform device/driver instead ? You declare bcm47xx_wdt_platform_device which is unused and you also declare a MODULE_ALIAS which suggets it is one. You are also missing your name in both the header the the MODULE_AUTHOR macro. -- Best regards, Florian Fainelli Email : florian@xxxxxxxxxxx http://openwrt.org -------------------------------