On Sun, May 31, 2009 at 08:29:07PM +0200, Florian Fainelli wrote: > This patch initializes mac_addr_used to zero, the checks > against it later would not work properly. > > Signed-off-by: Maxime Bizon <mbizon@xxxxxxxxxx> > Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx> > --- > diff --git a/arch/mips/bcm63xx/boards/board_bcm963xx.c b/arch/mips/bcm63xx/boards/board_bcm963xx.c > index 78a40e7..298804a 100644 > --- a/arch/mips/bcm63xx/boards/board_bcm963xx.c > +++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c > @@ -32,7 +32,7 @@ > #define PFX "board_bcm963xx: " > > static struct bcm963xx_nvram nvram; > -static unsigned int mac_addr_used; > +static unsigned int mac_addr_used = 0; Ditto - the variable defaults to zero. Explicit initialization however will inflate the .data section. Dropped. Ralf