Re: [PATCH 05/10] bcm63xx: dev-enet: initialize shared_device_registered to 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 31, 2009 at 08:28:37PM +0200, Florian Fainelli wrote:

> This patch initialize the shared_device_registered
> variable with 0, actually required for the check
> to be working.
> 
> Signed-off-by: Maxime Bizon <mbizon@xxxxxxxxxx>
> Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx>
> ---
> diff --git a/arch/mips/bcm63xx/dev-enet.c b/arch/mips/bcm63xx/dev-enet.c
> index 51c2e5a..0298973 100644
> --- a/arch/mips/bcm63xx/dev-enet.c
> +++ b/arch/mips/bcm63xx/dev-enet.c
> @@ -28,7 +28,7 @@ static struct platform_device bcm63xx_enet_shared_device = {
>  	.resource	= shared_res,
>  };
>  
> -static int shared_device_registered;
> +static int shared_device_registered = 0;

This is bogus.  The variable defaults to zero.  Explicit initialization
however will inflate the .data section.  Dropped.

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux