On Thu, Jan 15, 2009 at 12:04 AM, Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote: > Hello. > > Ihar Hrachyshka wrote: >> >> I think that's a better solution for the problem I said so please commit >> this patch rather previous one... >> > > Such comments are to be placed after --- tearline. Using several such > tearlines makes it harder to apply your patch... > And why do you expect the MIPS maintainer to commit a patch to the serial > driver? Such patches should be addressed to linux-serial@xxxxxxxxxxxxxxx and > (most probably) Alan Cox... I thought that if it's a driver for mips piece of hardware then I need to send it to mips guys. Ok, I'll send it to linux-serial. > >> --- >> >> Don't use ttyS[0-1] serial device name for board specific PNX8XXX UART >> serial. Rather create ttyPNX[0-1]. Also changed minor number to be >> different with sa1100 serial driver one. >> >> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@xxxxxxxxx> >> > > [...] >> >> diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c >> index 22e30d2..96870f1 100644 >> --- a/drivers/serial/pnx8xxx_uart.c >> +++ b/drivers/serial/pnx8xxx_uart.c >> @@ -34,9 +34,8 @@ >> #include <asm/io.h> >> #include <asm/irq.h> >> -/* We'll be using StrongARM sa1100 serial port major/minor */ >> #define SERIAL_PNX8XXX_MAJOR 204 >> -#define MINOR_START 5 >> +#define MINOR_START 96 >> > > This major-minor pair is reserved for the Altix serial cards. Have you > tried registering the minor on http://www.lanana.org Thanks for info. I sent the request. > > WBR, Sergei > > >