Re: [PATCH 2/3] Alchemy: Move evalboard code to common directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Wed, Nov 12, 2008 at 01:35:22PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> Kevin Hickey wrote:
>
>> And in keeping with my other email, I think that the evalboards
>> directory is a good idea (though I would recommend the name
>> "develboards" as that is what DB stands for), but it should contain
>>   
>
>   I'd prefer devel-boards, or dev-boards.

Can we settle on "devboards" without the hyphen?  Everybody okay with that?


>> subdirectories for each board and a common directory for common DB code.
>> Smashing all of the board code into one file doesn't leave any room to
>> grow if that file gets too big.
>
>   I doubt that this could be the case here. And I don't think anybody has 
> placed limits on the source file size so far.
>
>> Also, a single common.c will not be sufficient in the future.
>>   
>
>   Wait, the file only includes prom_init() for now, so might be worth 
> renaming it...

I planned on putting some of the code currently living in common/ into it.
Not a good idea?  Then I'll rename it to prom.c and leave it alone.


Thoughts?

Thanks,
	Manuel Lauss


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux