On Tue, 28 Oct 2008 11:52:20 +0100 Manuel Lauss <mano@xxxxxxxxxxxxxxxxxxxxxxx> wrote: > > I'd need some feedback from linux-mips, otherwise > > I can only Sign-off for the entries in drivers/rtc . > > I stripped the alchemy board parts away from the patch; they can go in > through the mips tree at a later time. ok. > > Btw why are you using a lock? the rtc class core > > already provides his own lock for the ops calls. > > Didn't know that; I mostly looked at rtc-sh.c for guidance which also > uses its own locks. I think it's due to the interrupt handling in rtc-sh. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it
