On Sat, Oct 25, 2008 at 12:17:25AM +0900, Yoichi Yuasa wrote: > ptrace.h needs #include <linux/types.h> > > In file included from include/linux/ptrace.h:49, > from arch/mips/kernel/kgdb.c:25: > /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:83: error: expected specifier-qualifier-list before 'uint32_t' > /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:98: error: expected specifier-qualifier-list before 'uint64_t' > In file included from include/linux/ptrace.h:49, > from arch/mips/kernel/kgdb.c:25: > /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:123: error: expected declaration specifiers or '...' before '__s64' > /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:124: error: expected declaration specifiers or '...' before '__s64' > /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:126: error: expected declaration specifiers or '...' before '__u32' > /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:127: error: expected declaration specifiers or '...' before '__u32' > make[1]: *** [arch/mips/kernel/kgdb.o] Error 1 > > Signed-off-by: Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> <asm/ptrace.h> is exported to userland so we can't include these types. Basically <linux/types.h> or <stdint.h> are polluting the namespace. So either we use some __* type and include only those or we get entirely rid of typedef'ed types - as in the patch that you've posted while I was writing this. Ralf
