Re: [PATCH] ide: Add tx4939ide driver (v5)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 21 October 2008, Sergei Shtylyov wrote:

> > +		pr_err("%s: Error interrupt %#x (%s%s%s )\n",
> > +		       hwif->name, ctl,
> > +		       (ctl & TX4939IDE_INT_ADDRERR) ?
> > +		       " Address-Error" : "",
> > +		       (ctl & TX4939IDE_INT_DEVTIMING) ?
> > +		       " DEV-Timing" : "",
> > +		       (ctl & TX4939IDE_INT_BUSERR) ?
> 
>     Parens around & shouldn't be needed...

While the above remark is certainly correct we usually leave such parens
to ease the reading of the code and to match the other parts of the kernel...

[ No need to change it again, just a minor note... ]


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux