Re: [PATCH] TXx9: Add TX4938 ATA support (v2)

[Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>]

Hello.

Atsushi Nemoto wrote:

> Add a helper routine to register tx4938ide driver and use it on
> RBTX4938 board.
>
> Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
>   

Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

> diff --git a/arch/mips/include/asm/txx9/tx4938.h b/arch/mips/include/asm/txx9/tx4938.h
> index 989e775..3dada66 100644
> --- a/arch/mips/include/asm/txx9/tx4938.h
> +++ b/arch/mips/include/asm/txx9/tx4938.h
> @@ -292,4 +292,17 @@ void tx4938_setup_pcierr_irq(void);
>  void tx4938_irq_init(void);
>  void tx4938_mtd_init(int ch);
>  
> +struct tx4938ide_platform_info {
> +	/*
> +	 * I/O port shift, for platforms with ports that are
> +	 * constantly spaced and need larger than the 1-byte
> +	 * spacing used by ata_std_ports().
> +	 */
> +	unsigned int ioport_shift;
> +	unsigned int gbus_clock;	/*  0 means no-autotune. */
>   

  I'd say "no PIO mode tuning" since the mode can also be changed via 
HDIO_SET_PIO_MODE which e.g. 'hdparm -p' calls...

> diff --git a/arch/mips/txx9/generic/setup_tx4938.c b/arch/mips/txx9/generic/setup_tx4938.c
> index af724e5..e6c558e 100644
> --- a/arch/mips/txx9/generic/setup_tx4938.c
> +++ b/arch/mips/txx9/generic/setup_tx4938.c
>   
[...]
> @@ -335,6 +336,52 @@ void __init tx4938_mtd_init(int ch)
>  	txx9_physmap_flash_init(ch, start, size, &pdata);
>  }
>  
> +void __init tx4938_ata_init(unsigned int irq, unsigned int shift, int tune)
> +{
> +	struct platform_device *pdev;
> +	struct resource res[] = {
> +		{
> +			/* .start and .end are filled in later */
> +			.flags = IORESOURCE_MEM,
> +		}, {
> +			.start = irq,
> +			.flags = IORESOURCE_IRQ,
> +		},
> +	};
> +	struct tx4938ide_platform_info pdata = {
> +		.ioport_shift = shift,
> +		/*
> +		 * The ide driver should not do autotune if other ISA
>   

 "The IDE driver should not change bus timings", I'd say.

MBR, Sergei