Re: [PATCH 1/4] serial: 8250 driver replaceable i/o functions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Daney wrote:
/* sane hardware needs no mapping */
-static inline int map_8250_in_reg(struct uart_8250_port *up, int offset)
+static inline int map_8250_in_reg(struct uart_port *p, int offset)
{
-    if (up->port.iotype != UPIO_AU)
+    if (p->iotype != UPIO_AU)
        return offset;
    return au_io_in_map[offset];
}

With your changes, these functions cannot be called with p->iotype != UPIO_AU anymore, correct? So there is no need for this test...

	-hpa


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux