On Tue, 23 Sep 2008 00:16:02 +0900 (JST) Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > On Mon, 22 Sep 2008 19:01:57 +0400, Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote: > > >> BTW, how about supporting IDE aboard RBTX4938, not worth the trouble? > > > > > Yes, next plan. It should be much simpler than the tx4939ide driver. > > > > I suspect {ide|pata}_platform could be able to cover it... though I got > > muddled in the timing diagrams for the TX4938 external bus... > > We need .set_pio_mode routine to get best PIO speed, but current > {ide|pata}_platform driver does not provide a hook for it (please > correct me if I was wrong). So current code I have does not use > ide_platform... You are correct. The platform driver is intended to be totally dumb. It's not clear at what point having a specific driver is more sensible as a libata driver is tiny anyway (especially with tejuns inherited ops stuff)