Hello, I wrote:
This controller has standard ATA taskfile registers and DMA
command/status registers, but the register layout is swapped on big
endian. There are some other endian issue and some special registers
which requires many custom dma_ops/port_ops routines.
Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
I thought that I'd only have the stylyistic comments and ACK the
patch but it shouldn't even compile... :-/
Hm, it should compile in the context of linux-next tree..
+static void tx4939ide_set_pio_mode(ide_drive_t *drive, const u8 pio)
+{
+ ide_hwif_t *hwif = HWIF(drive);
+ int is_slave = drive->dn & 1;
+ u32 mask, val;
+ u8 safe = pio;
+ ide_drive_t *pair;
+
+ pair = ide_get_pair_dev(drive);
Wait, have you tried to compile this driver? The function is called
ide_get_paired_drive() -- and I did name it correctly in my previous
review.
I didn't realize that Bart has renamed the function in one of the
pending patches...
MBR, Sergei
