Re: [PATCH] Au1200 USB Device Controller and device-only OTG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 11 September 2008, Kevin Hickey wrote:
> basic device-only OTG (On-The-Go) support

That does't look like it's done right.  For starters, it abuses
Kconfig to handle a board-specific config option.  Put that data
in platform_data instead ...

Second, it breaks some previously-working code.

Third, it misbehaves even on an x86 config.  Needs something like
the appended patch.

- Dave


--- g26.orig/drivers/usb/gadget/Kconfig	2008-09-15 12:10:22.000000000 -0700
+++ g26/drivers/usb/gadget/Kconfig	2008-09-15 12:10:06.000000000 -0700
@@ -490,7 +490,7 @@ config USB_GADGET_DUALSPEED
 
 config USB_PORT_AU1200OTG
 	boolean "AU1200 USB portmux control (On-The-Go support)"
-	depends on USB_GADGET_AU1200 || USB_EHCI_HCD || USB_OHCI_HCD
+	depends on USB_GADGET_AU1200 && (USB_EHCI_HCD || USB_OHCI_HCD)
 	default n
 	help
 	   The AU1200 and Au1200 USB device port can be used as either a host



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux