On Thu, 11 Sep 2008, Florian Fainelli wrote: > MIPS include types.h says that using phys_t is bad, which in > fact is an unsigned long, so use an unsigned long directly. That is bad indeed. A physical address might not fit in unsigned long. Actually the upstream is apparently adopting phys_addr_t for this purpose right now, so you might consider waiting with your patch till the thing settles down. Note that by using a generic type you take away semantics which will make future adjustments more difficult. Maciej
