Florian Fainelli wrote:
This patch fixes the misuse of virtual address which would lead to serious problems while accessing ioremap'd registers in the GPIO code.
Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx> --- diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c index 00a1c78..3d1632c 100644 --- a/arch/mips/rb532/gpio.c +++ b/arch/mips/rb532/gpio.c @@ -47,8 +47,8 @@ struct mpmc_device dev3; static struct resource rb532_gpio_reg0_res[] = { { .name = "gpio_reg0", - .start = (u32)(IDT434_REG_BASE + GPIOBASE), - .end = (u32)(IDT434_REG_BASE + GPIOBASE + sizeof(struct rb532_gpio_reg)), + .start = (REG_BASE + GPIOBASE), + .end = (REG_BASE + GPIOBASE + sizeof(struct rb532_gpio_reg)), .flags = IORESOURCE_MEM, } }; @@ -56,8 +56,8 @@ static struct resource rb532_gpio_reg0_res[] = { static struct resource rb532_dev3_ctl_res[] = { { .name = "dev3_ctl", - .start = (u32)(IDT434_REG_BASE + DEV3BASE), - .end = (u32)(IDT434_REG_BASE + DEV3BASE + sizeof(struct dev_reg)), + .start = (REG_BASE + DEV3BASE), + .end = (REG_BASE + DEV3BASE + sizeof(struct dev_reg)), .flags = IORESOURCE_MEM, } };
Oh, and parens are not needed in the initializers anymore... WBR, Sergei