On Thu, Aug 07, 2008 at 11:03:07AM +0200, Geert Uytterhoeven wrote: > > > + priv = kzalloc(sizeof *priv, GFP_KERNEL); > > > > sizeof(struct ds1286_priv) is a little bit cleaner. > > What if the type of priv changes? Then this code will more changes anyway ... Ralf
