On Thu, 7 Aug 2008 11:03:07 +0200 (CEST) Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > sizeof(struct ds1286_priv) is a little bit cleaner. > > What if the type of priv changes? It shouldn't in such a small context . however, it is not required, is just my personal preference about readability. parentheses around the sizeof are, ont he other side, required. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it