On Thu, 2008-06-05 at 13:11 +0200, Martin Michlmayr wrote: > * Martin Michlmayr <tbm@xxxxxxxxxx> [2008-05-28 09:06]: > > * Ralf Baechle <ralf@xxxxxxxxxxxxxx> [2008-05-13 05:50]: > > > I prefer to do it myself so I can apply it at the same time to the MIPS > > > -stable branches. > > > > > > I'm a little irriated that this thread seems to be only about > > > empty_zero_page but apparently not zero_page_mask? empty_zero_page is > > > actualy an array of pages on MIPS and ZERO_PAGE() will pick the right one > > > for a particular user space mapping based on the virtual address but > > > ZERO_PAGE() also references zero_page_mask. So I sense more brokenness > > > here. > > > > Just as a reminder, this issue is still there (at least with rc4). > > Still present in rc5. It looks like the discussion related to this issue has faded out. Ralf seemed to have some objections to using ZERO_PAGE() outside of the context of getting a user-mapped page, but I think that ext4 driver is still doing that. Ralf, will it be possible to use the patch I sent earlier as a temporary solution? Just to make sure the kernel builds? Thanks, Dmitri >