On Thu, Jan 10, 2008 at 05:10:05PM +0300, Vitaly Wool wrote: > This patch converts PNX8XXX system timer to clocksource. Checkpatch had a little to moan on your patch: $ scripts/checkpatch.pl /tmp/pend ERROR: use tabs not spaces #79: FILE: arch/mips/philips/pnx8550/common/time.c:57: + struct clock_event_device *c = dev_id;$ ERROR: use tabs not spaces #81: FILE: arch/mips/philips/pnx8550/common/time.c:59: + /* clear MATCH, signal the event */$ ERROR: use tabs not spaces #82: FILE: arch/mips/philips/pnx8550/common/time.c:60: + c->event_handler(c);$ Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. I fixed those, applied. Thanks! Ralf
