On Mon, Nov 26, 2007 at 06:41:15PM +0100, Thomas Bogendoerfer wrote: > Following patch is 2.6.25 material needed to get SGI IP28 machines > supported. > > Thomas. > > SGI IP28 machines would need special treatment (enable adding addtional > wait states) when accessing memory uncached. To avoid this pain I > changed the driver to use only cached access to memory. > > Signed-off-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> Same comment as for SGISEEQ: IP28 is clearly a maximum weirdo beast. Technically the patch looks fine it's just a few stilistic issues such as there no reason for DMA_SYNC_DESC_CPU and DMA_SYNC_DESC_DEV being macros so why not using inlines. Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> Ralf