On Thu, Nov 22, 2007 at 04:19:35PM +0000, Ralf Baechle wrote: > > This might broke probe_irq_on()/probe_irq_off(), since > > handle_percpu_irq() does not check IRQ_WAITING bit. > > Ok - but does that matter at all? IRQ probing is only used with ISA > drivers and for those there will be another interrupt controller such as > a i8259 PIC daisy chained to one of the CPU interrupt pins. Ah, I think I now understand the problem. Seems like no interrupt should ever use IRQ_NOPROBE except ISA interrupts but unfortunately that flag is not everywhere where it should. Maybe the logic should even be negated and the flag become IRQ_PROBE ... Ralf