Hello.
Ralf Baechle wrote:
Sergei Shtylyov wrote:
Could also add spaces between the operands and operators (like
above/below), while at it...
like this?
Thanks. I didn't like the magic numbers in the code so I went for below
patch instead.
Cheers,
Ralf
From: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
[MIPS] IRIX: Fix off-by-one error in signal compat code.
Based on original patch by Roel Kluin <12o3l@xxxxxxxxxx>.
Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
I'm afraid this new patch is wrong...
diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c
index a0a9105..5052f47 100644
--- a/arch/mips/kernel/irixsig.c
+++ b/arch/mips/kernel/irixsig.c
@@ -24,8 +24,12 @@
#define _BLOCKABLE (~(_S(SIGKILL) | _S(SIGSTOP)))
+#define _IRIX_NSIG 128
+#define _IRIX_NSIG_BPW BITS_PER_LONG
+#define _IRIX_NSIG_WORDS (_IRIX_NSIG / _IRIX_NSIG_BPW)
+
typedef struct {
- unsigned long sig[4];
+ unsigned long sig[_IRIX_NSIG_WORDS];
} irix_sigset_t;
struct sigctx_irix5 {
@@ -527,7 +531,7 @@ asmlinkage int irix_sigpoll_sys(unsigned long __user *set,
expire = schedule_timeout_interruptible(expire);
- for (i=0; i<=4; i++)
+ for (i=0; i < _IRIX_NSIG_BPW; i++)
Did you mean _IRIX_NSIG_WORDS? :-/
tmp |= (current->pending.signal.sig[i] & kset.sig[i]);
if (tmp)
WBR, Sergei
