Re: [MIPS] Fix aliasing bug in copy_user_highpage, take 2.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 15 Oct 2007 19:28:11 +0100, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote:
> After copy_from_user_page the page will reside in the D-cache.  So just
> in case it ever gets mapped to userspace and modified there we better
> make sure its kernel address will get flushed before mapping it to user
> space.  If not, we might see stale data if the page got modified under
> its userspace address.

Hmm, setting SetPageDcacheDirty() will not make sure the modified data
flushed before reading via the kernel mapping.  The flush_dcache_page()
should be used for such case, shouldn't it?

---
Atsushi Nemoto


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux