Re: [MIPS] Fix aliasing bug in copy_user_highpage, take 2.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 15 Oct 2007 16:47:30 +0100, linux-mips@xxxxxxxxxxxxxx wrote:
> Turns out 6a36458d9348265327d074bdd40bfb1c5b6fb2cb  wasn't quite right.
> When called for a page that isn't marked dirty it would artificially
> create an alias instead of doing the obvious thing and access the page
> via KSEG0.
> 
> The same issue also exists in copy_to_user_page and copy_from_user_page
> which was causing the machine to die under rare circumstances for example
> when running ps if the BUG_ON() assertion added by the earlier fix was
> getting triggered.

This commit added a SetPageDcacheDirty() call for both
copy_to_user_page() and copy_from_user_page().  The call in
copy_from_user_page() is really needed?

---
Atsushi Nemoto


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux