On Thu, 13 Sep 2007 11:29:17 +0900 (JST) Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > On Thu, 13 Sep 2007 11:04:04 +0900, Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> wrote: > > diff -pruN -X mips/Documentation/dontdiff mips-orig/include/asm-mips/hw_irq.h mips/include/asm-mips/hw_irq.h > > --- mips-orig/include/asm-mips/hw_irq.h 2007-09-13 10:41:51.559222750 +0900 > > +++ mips/include/asm-mips/hw_irq.h 2007-09-13 10:39:56.480030750 +0900 > > @@ -8,15 +8,8 @@ > > #ifndef __ASM_HW_IRQ_H > > #define __ASM_HW_IRQ_H > > > > -#include <linux/profile.h> > > #include <asm/atomic.h> > > This breaks some build. > > linux/arch/mips/kernel/time.c:142: error: implicit declaration of function 'profile_tick' > > Proper fix would be including profile.h from time.c, but this is > irrelevant to i8259, so should be a separate patch. I found a patch for it in my patch queue. > Other parts looks good to me. Thanks. Add #include <linux/profile.h> to arch/mips/kernel/time.c It refer to CPU_PROFILING. arch/mips/kernel/time.c: In function 'local_timer_interrupt': arch/mips/kernel/time.c:142: error: implicit declaration of function 'profile_tick' arch/mips/kernel/time.c:142: error: 'CPU_PROFILING' undeclared (first use in this function) arch/mips/kernel/time.c:142: error: (Each undeclared identifier is reported only once arch/mips/kernel/time.c:142: error: for each function it appears in.) Signed-off-by: Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/kernel/time.c mips/arch/mips/kernel/time.c --- mips-orig/arch/mips/kernel/time.c 2007-09-12 11:10:18.577854500 +0900 +++ mips/arch/mips/kernel/time.c 2007-09-12 14:15:48.490857250 +0900 @@ -16,6 +16,7 @@ #include <linux/init.h> #include <linux/sched.h> #include <linux/param.h> +#include <linux/profile.h> #include <linux/time.h> #include <linux/timex.h> #include <linux/smp.h>
