On Thu, 13 Sep 2007 11:04:04 +0900, Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> wrote: > diff -pruN -X mips/Documentation/dontdiff mips-orig/include/asm-mips/hw_irq.h mips/include/asm-mips/hw_irq.h > --- mips-orig/include/asm-mips/hw_irq.h 2007-09-13 10:41:51.559222750 +0900 > +++ mips/include/asm-mips/hw_irq.h 2007-09-13 10:39:56.480030750 +0900 > @@ -8,15 +8,8 @@ > #ifndef __ASM_HW_IRQ_H > #define __ASM_HW_IRQ_H > > -#include <linux/profile.h> > #include <asm/atomic.h> This breaks some build. linux/arch/mips/kernel/time.c:142: error: implicit declaration of function 'profile_tick' Proper fix would be including profile.h from time.c, but this is irrelevant to i8259, so should be a separate patch. Other parts looks good to me. Thanks. --- Atsushi Nemoto