Re: [PATCH -mm 2/4] MIPS: BCM947xx support (v2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Florian Schirmer a écrit :
> Hi,
> 
> Aurelien Jarno wrote:
>> The patch below against 2.6.23-rc1-mm2 adds support for BCM947xx CPUs.
>> It originally comes from the OpenWrt patches.
>>
>> Cc: Michael Buesch <mb@xxxxxxxxx>
>> Cc: Waldemar Brodkorb <wbx@xxxxxxxxxxx>
>> Cc: Felix Fietkau <nbd@xxxxxxxxxxx>
>> Cc: Florian Schirmer <jolt@xxxxxxxxxx>
>> Signed-off-by: Aurelien Jarno <aurelien@xxxxxxxxxxx>
>>   
> 
> I'm not sure whether it's a good idea to export a symbol named "ssb". 
> Maybe bcm47xx_ssb would be a better name? I've no idea what the general 
> rule on exporting symbols is though. Otherwise:

I don't not either, but looking in other parts of the kernel it seems it
is done the other way, ie ssb_bcm947xx would be the correct name.

I will send an updated patch.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@xxxxxxxxxx         | aurelien@xxxxxxxxxxx
   `-    people.debian.org/~aurel32 | www.aurel32.net


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux