On Wednesday 11 July 2007, Christoph Hellwig wrote: > On Wed, Jul 11, 2007 at 11:32:20AM +0200, Domen Puncer wrote: > > clk interface for arch/powerpc, platforms should fill > > clk_functions. > > Umm, this is about the fifth almost identical implementation of > the clk_ functions. Please, please put it into common code. > > And talk to the mips folks which just got a similar comment from me. You mean like a lib/clock.c core, rather than an opsvector? ISTR that allowing custom platform-specific implementations was intended to be a feature. But it's also true that some folks see lack of shared implementation code as a drawback; so I've CC'd Russell King (who originated the interface for ARM platforms). - Dave