On Tue, Jun 19, 2007 at 02:12:56PM -0700, Andrew Morton wrote:
> > +/* Define the following for extra debug output */
> > +#undef DEBUG
>
> The under shouldn't be needed: -DDEBUG can be provided on the kbuild
> command line.
>
> > +#ifdef DEBUG
> > +#define DBG(args...) printk(KERN_DEBUG args)
> > +#else
> > +#define DBG(args...) do {} while (0)
> > +#endif
<linux/kernel.h> provides the equivalent pr_debug function so this
definition of DBG is redundant.
Ralf
