Marc, > ----- Forwarded message from Marc St-Jean <stjeanma@xxxxxxxxxxxxxx> ----- > > From: Marc St-Jean <stjeanma@xxxxxxxxxxxxxx> > Date: Fri, 16 Mar 2007 15:39:51 -0600 > To: akpm@xxxxxxxxxxxxxxxxxxxx > Cc: linux-mips@xxxxxxxxxxxxxx > Subject: [PATCH 8/12] drivers: PMC MSP71xx TWI driver > > [PATCH 8/12] drivers: PMC MSP71xx TWI driver > > Patch to add TWI driver for the PMC-Sierra MSP71xx devices. > > Reposting patches as a single set at the request of akpm. > Only 9 of 12 will be posted at this time, 3 more to follow > when cleanups are complete. > > CCing linux-mips.org since minor changes have occured > during cleanup of driver patches for other lists. > > Thanks, > Marc > > Signed-off-by: Marc St-Jean <Marc_St-Jean@xxxxxxxxxxxxxx> > --- > Re-posting patch with recommended changes: > -No changes. > > drivers/i2c/algos/Kconfig | 9 > drivers/i2c/algos/Makefile | 1 > drivers/i2c/algos/i2c-algo-pmctwi.c | 197 ++++++++++++++++ > drivers/i2c/busses/Kconfig | 7 > drivers/i2c/busses/Makefile | 1 > drivers/i2c/busses/i2c-pmcmsp.c | 419 ++++++++++++++++++++++++++++++++++++ > include/linux/i2c-algo-pmctwi.h | 135 +++++++++++ > 7 files changed, 768 insertions(+), 1 deletion(-) Why are you making a separate algorithm driver? This should really only be done when the algorithm is very generic. This is the exception, not the rule. These days I tend to move algorithm code back into the only bus driver that uses them (i2c-algo-sibyte done recently, i2c-algo-sgi is next on my list.) > > diff --git a/drivers/i2c/algos/Kconfig b/drivers/i2c/algos/Kconfig > index af02034..794f7bb 100644 > --- a/drivers/i2c/algos/Kconfig > +++ b/drivers/i2c/algos/Kconfig > @@ -49,5 +49,12 @@ config I2C_ALGO_SGI > Supports the SGI interfaces like the ones found on SGI Indy VINO > or SGI O2 MACE. > > -endmenu > +config I2C_ALGO_PMCTWI > + tristate "I2C PMC TWI interfaces" > + depends on I2C && PMC_MSP As a matter of fact, each time an algorithm depends on specific hardware, you can be reasonably certain that it should NOT be made a generic algorithm driver. > + help > + Implements the PMC TWI SoC algorithm for various implementations. > > + Be sure to select the proper bus for your platform below. > + > +endmenu -- Jean Delvare
