Hi, On 3/10/07, peter fuerst <post@xxxxxxxx> wrote:
3) The page_offset adjustment may force fixes in other, not yet blown up, places (pmd_phys() cried out lately...).
Not really fair. It crashed lately because until now I was the only one to use it. And unfortunately I failed to give back this change to Ralf's tree. BUT, note that the root cause of this bug is that we did _plain_ address translation instead of using dedicated macro. So I would say that this patch helps to fix these buggy places.
What can PHYS_OFFSET achieve here - besides obfuscating ? Are there future uses for it, that justify the contortions ?
How do you deal with fancy cases such as physical memory starting at 0x20000000 for example ? -- Franck