On Wed, 14 Feb 2007 09:34:53 +0100, "Franck Bui-Huu" <vagabon.xyz@xxxxxxxxx> wrote: > > +/* Check and clear pending FPU exceptions in saved CSR */ > > +extern int fpcsr_pending(unsigned int __user *fpcsr); > > + > > Just my 2 cents: This looks like the wrong place for this fpu > prototype. I mean shouldn't it belong to a fpu header file or > something else ? Well, this is a helper function for signal so signal-common.h is not so bad, I think. And adding to kernel/signal-common.h looks less intrusive than adding to include/asm-mips/fpu.h, in my impression. --- Atsushi Nemoto