Re: [PATCH] rest of works for migration to GENERIC_TIME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 23 Oct 2006 18:38:37 +0400, Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote:
> > * mips_hpt_mask variable to specify bitmask of hpt value.
> 
>     There's actually no need to introduce more variables. Just make
> clocksource declaration public and override default mask if
> necessary.
>     Also, I don't see much sense in further existence of
> mips_hpt_read() -- it only causes each clocksource read go thru a
> double indirection which is really ugly. The same approach shouyld
> be used here.

I agree with you that it would be a way to go.  For now exporting
clocksource_mips just to override the mask and keep using
mips_hpt_read looks somewhat inconsistent, so I just added
mips_hpt_mask variable.

Replacing mips_hpt_read involves changes for _all_ platform code so I
think it would be better to do it on next -rc1 stage.

---
Atsushi Nemoto


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux