Wouldn't it be better to check the macro in the preprocessor instead of runtime? And why are those defined to 0 instead of explicitly undef'ed? I've found one bug because it was assumed to be undefined instead of 0. If no one objects I'll post a patch undefing those and fix any bugs I've found because of them. On Fri, 13 Oct 2006 15:11:01 +0100 Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote: > On Fri, Oct 13, 2006 at 09:53:05AM -0400, Antonio SJ Musumeci wrote: > > > Should I apply my patch on top of this one? > > No, the two patches conflict in what they're doing. The important > part of your patch, the fix to the if condition I've already applied. > > Ralf >
