On Wed, 27 Sep 2006 00:20:30 +0900, girish <girishvg@xxxxxxxxx> wrote: > But, then again treating all addresses as above PAGE_OFFSET is also wrong :) It would be a design not a bug :-) > I looked at it just as a work around. These macros are called from so many > other places that if an access is made at say 4000_0000 the kernel will oops > telling it was C000_0000 access error. Now that confused me a lot! With this > change now kernel oops on 4000_0000 :) Yes, 4000_0000, which is wrong too. And it _hides_ wrong usage of vaddr/paddr. Bad side effect :) > Anyway, you may ignore __pa/__va macros. > > Could you please look into other changes I proposed? __pa() returns "unsigned long" and __va() returns "void *" so some casts are also redundant. Other parts looks good for me. --- Atsushi Nemoto
