Re: [PATCH 2/3] [MIPS] lockdep: add STACKTRACE_SUPPORT and enable LOCKDEP_SUPPORT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 26 Sep 2006 17:58:12 +0200, Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> wrote:
> > +static inline void
> > +save_raw_context_stack(struct stack_trace *trace, unsigned int skip,
> > +		       unsigned long reg29)
> > +{
> [snip]
> > +
> > +static inline struct pt_regs *
> > +save_context_stack(struct stack_trace *trace, unsigned int skip,
> > +		   struct task_struct *task, struct pt_regs *regs)
> > +{
> > +	unsigned long sp = regs->regs[29];
> 
> Any reasons why marking these 2 functions as inlined ? IMHO gcc is now
> good enough for this decision.

Indeed.  I just made them inlined because I used i386's stacktrace.c
as a template :-)

---
Atsushi Nemoto


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux