Re: N32 sigset and __COMPAT_ENDIAN_SWAP__

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 08, 2006 at 01:03:10PM -0400, Daniel Jacobowitz wrote:

> Anyway, I was curious if you knew where this code had come from.  I
> didn't see anything to suggest that anyone besides mipsel ever
> used it, but it entered linux-mips.org via a merge from kernel.org,
> just before git history.
> 
> Oh, right, there's a historical import:
> 
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commitdiff;h=32ed691a4efbc1c43584b7b7a6d782528241bb27

> It was copied from sys32_rt_sigtimedwait, which was wrong at least back
> to the initial revision of signal32.c.  I didn't go back any further.

I can further track it into 2.4 or even pre-2.4 where such
__MIPSEB__ / __MIPSEL__ dependencies did exist under arch/mips64/.
I think it was right until a certain point in 2.5 when
get_sigset and put_sigset were implement in a clever way that
automatically takes care of the endianess issue - but the swapping code
outside arch/mips got forgotten.

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux