Jordan Crouse wrote:
On 19/05/06 18:48 +0400, Sergei Shtylyov wrote:
Alas, I have to NAK this. DBAu1200 code should be in
arch/mips/au1000/pb1200/...
if this was DB1200 code only, I would be inclined to agree, but its
not - so this code is well placed.
It's under #ifdef CONFIG_MIPS_DB1200, so is *completely* misplaced. This
file is not even compiled for DBAu1200. Therefore, this code will never execute.
Thou wait... that hunk won't even aplly to the current git tree...
Well, it does apply - latest GIT tree, right from l-m.o
Hmm, indeed it applies with fuzz (because of PSC redefinitions)... So, I'm
taking this back. :-)
Looks like this patch is trying to redeclare PSC base addresses for Au1200
Yeah, it does a redundant declaration - I'll pull that part of it. The
rest of the patch is still valid though - I see no reason why you should NAK
it, especially when this was posted by popular request.
Because I caught a defect in it with naked eye. Maybe NAKing it was indeed
too much. :-)
Jordan
MBR, Sergei
