Re: [PATCH] fix mips/Makefile to support CROSS_COMPILE from environment var

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 4 May 2006, Tom Rini wrote:
> On Thu, May 04, 2006 at 04:14:32PM -0700, Tom Rini wrote:
> > On Fri, May 05, 2006 at 12:06:47AM +0100, Ralf Baechle wrote:
> > > On Thu, May 04, 2006 at 02:04:49PM -0700, Tom Rini wrote:
> > > 
> > > > Let me ask a stupid question.  With all of the ways to otherwise do a
> > > > cross compile, why a config option on MIPS?  ARM*/SH*, which are at
> > > > least as likely to not be native-compiled, don't do that.  Just
> > > > something I've always wondered, really.
> > > 
> > > Having such information in an environment variable is imho terribly
> > > inelegant, having to pass it on the command line for each make invocation
> > > is terrible abuse for the fingertips so I went for this option which makes

You can make it so that you can use both, right? This is what the suggested
patch does. No CROSS_COMPILE in env or on the make command line means a native
compilation.

> > > the makefile pick the right prefix.
> > 
> > I don't suppose you'd be willing to front pushing that to the rest of
> > the world then, would you?  Inconsistency is more of a problem for me
> > than changing any of my scripts to use something else :)
> 
> ... I forgot this doesn't take a string value of what to use but
> hard-coded options.

So let it take a string option, and make it generic.

But on second thought: config options are part of the target configuration,
while CROSS_COMPILE= is part of the host configuration, so IMHO it doesn't
belong in Kconfig. I.e. do you want to have CONFIG_CROSS_COMPILE set in your
defconfig? Yes or no, depending on whether you do cross-compilations or not. So
you cannot simply take a defconfig, you'll have to modify it for your host
setup.

So I'd prefer to keep the CROSS_COMPILE, like other arches do.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux