On Thu, 13 Oct 2005 23:55:21 +0100, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote: > > The problem is if you try to load oprofile as a module. The kernel > > module linker evidentially does not understand weak symbols and refuses > > to load the module because they are undefined. > > Actually it contains code to handle weak symbols so this is a bit > surprising not last because STB_WEAK handling happen in the generic > module loader code and is being used by other architectures as well. This is still unresolved. The "oprofile: Unknown symbol" message is printed in arch/mips/kernel/module.c file. How about this patch? [PATCH] Ignore unresolved weak symbols in module. Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx> diff --git a/arch/mips/kernel/module.c b/arch/mips/kernel/module.c index e54a7f4..d7bf021 100644 --- a/arch/mips/kernel/module.c +++ b/arch/mips/kernel/module.c @@ -288,6 +288,9 @@ int apply_relocate(Elf_Shdr *sechdrs, co sym = (Elf_Sym *)sechdrs[symindex].sh_addr + ELF_MIPS_R_SYM(rel[i]); if (!sym->st_value) { + /* Ignore unresolved weak symbol */ + if (ELF_ST_BIND(sym->st_info) == STB_WEAK) + continue; printk(KERN_WARNING "%s: Unknown symbol %s\n", me->name, strtab + sym->st_name); return -ENOENT; @@ -325,6 +328,9 @@ int apply_relocate_add(Elf_Shdr *sechdrs sym = (Elf_Sym *)sechdrs[symindex].sh_addr + ELF_MIPS_R_SYM(rel[i]); if (!sym->st_value) { + /* Ignore unresolved weak symbol */ + if (ELF_ST_BIND(sym->st_info) == STB_WEAK) + continue; printk(KERN_WARNING "%s: Unknown symbol %s\n", me->name, strtab + sym->st_name); return -ENOENT;