On Mon, 13 Feb 2006, Martin Michlmayr wrote: > OK, I got it down to: > > CC drivers/tc/lk201.o > drivers/tc/lk201.c: In function ‘lk201_rx_char’: > drivers/tc/lk201.c:361: warning: implicit declaration of function ‘handle_scancode’ > drivers/tc/lk201.c: In function ‘lk201_init’: > drivers/tc/lk201.c:405: error: invalid lvalue in assignment > drivers/tc/lk201.c:406: error: invalid lvalue in assignment > make[2]: *** [drivers/tc/lk201.o] Error 1 > > But this driver really needs to be ported to the new input interface. The driver has been ported by JBG (thanks!) -- it's the zs.c driver that needs to be ported to the new serial infrastructure. But that's tough if to be done properly (DMA and synchronous modes are not handled well by the serial core), so not at the moment, sorry. I'll think about minimal functionality to keep it going though and perhaps lk201.c could be changed to work with current zs.c as is (dz.c has already been ported -- I have no way of testing it, so I somewhat lack incentive to go through it and verify if it's at least as good as the old driver in 2.4.)... I'm not sure what your patch is meant to do, but if changing rate to period you need to invert the values as well -- period = 1 / rate -- and the hardware expects rates in cps IIRC; mind the units, though. Maciej
