Hi Ralf 2006/1/25, Ralf Baechle <ralf@xxxxxxxxxxxxxx>: > On Wed, Jan 25, 2006 at 10:36:46AM +0100, Franck wrote: > > > Here is a little patch to optimize swab operations by using "wsbh" > > instruction available on mips revision 2 cpus. I do not know what > > condition I should use to compile this only for mips r2 cpu though. > > > > Comments ? > > Looks good aside of the one issue you've already raised yourself: > > > +/* FIXME: MIPS_R2 only */ > I was actually asking for advices :) I can see only two simple ways to do that: (a) we can define a couple of new macro ie CONFIG_MIPS32_ISET_R[12] that can be set depending on the selected CPU; (b) define a new macro CONFIG_CPU_HAS_WSBH; What do you think ? Thanks -- Franck