>>>>> On Wed, 28 Dec 2005 13:25:44 +0900 (JST), Atsushi Nemoto <anemo@xxxxxxxxxxxxx> said: anemo> * The uart_console() returns 1 even if the console was not anemo> successfully configured (CON_ENABLED was not set and spinlock anemo> did not initialized). So uart_add_one_port() does not anemo> initialize the spinlock for the console. This is same for the 8250 driver which also can handle PCI and legacy ports. The 8250 driver is working correctly just because serial8250_isa_init_ports() initializes all spinlocks. If this way a right way, spin_lock_init() in uart_add_one_port() seems redundant... --- Atsushi Nemoto