Re: [PATCH] Fix board type in db1x00

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

> > +	/* Set the platform # */
> > +#if	defined (CONFIG_MIPS_DB1550)
> > +	mips_machtype = MACH_DB1550;
> > +#elif	defined (CONFIG_MIPS_DB1500)
> > +	mips_machtype = MACH_DB1500;
> > +#elif	defined (CONFIG_MIPS_DB1100)
> > +	mips_machtype = MACH_DB1100;
> > +#else
> > +	mips_machtype = MACH_DB1000;
> > +#endif
> 
> Can't we just do something like
> 	#define MACH_ALCHEMY_TYPE  xxxxx
> 
> in the include files and not have this mess in the
> actual code?  Then, all we have to do here is:
> 
> 	mips_machtype = MACH_ALCHEMY_TYPE;

I prefer Dan's suggestion, if it counts.

And please, don't forget about DB1200 board also.
I already sent some minor patches, but they didn't
get in :(

BR,
Matej



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux