On 22/11/05 17:31 -0500, Dan Malek wrote: > > On Nov 22, 2005, at 5:15 PM, Jordan Crouse wrote: > > >+ /* Set the platform # */ > >+#if defined (CONFIG_MIPS_DB1550) > >+ mips_machtype = MACH_DB1550; > >+#elif defined (CONFIG_MIPS_DB1500) > >+ mips_machtype = MACH_DB1500; > >+#elif defined (CONFIG_MIPS_DB1100) > >+ mips_machtype = MACH_DB1100; > >+#else > >+ mips_machtype = MACH_DB1000; > >+#endif > > Can't we just do something like > #define MACH_ALCHEMY_TYPE xxxxx > > in the include files and not have this mess in the > actual code? Then, all we have to do here is: > > mips_machtype = MACH_ALCHEMY_TYPE; The problem with db1x00 in particular is that its sort of a catch all for all the Alchemy boards that don't have a proper home of their own, so there really isn't a DB1000/DB1100/DB1500/DB1550 header file. That means either the mess goes in here or it goes in asm-mips/mach-db1x00/db1x00.h, and I think I rather prefer it to be in the .c file, just so one doesn't have to chase down the MACH_ALCHEMY_TYPE define. Jordan -- Jordan Crouse Senior Linux Engineer AMD - Personal Connectivity Solutions Group <www.amd.com/embeddedprocessors>
