On Mon, Sep 13, 2004 at 03:33:09PM -0700, Peter Buckingham wrote: > diff -u -r1.36 atomic.h > --- include/asm-mips/atomic.h 19 Aug 2004 09:54:23 -0000 1.36 > +++ include/asm-mips/atomic.h 13 Sep 2004 21:51:56 -0000 > @@ -26,7 +26,7 @@ > #include <asm/cpu-features.h> > #include <asm/war.h> > > -extern spinlock_t atomic_lock; > +static spinlock_t atomic_lock; > > typedef struct { volatile int counter; } atomic_t; No. atomic_lock is intentionally undefined, so this patch seems very broken. Ralf